fix: await MCP notification in screenshot tool#141
Merged
Conversation
monadoid
approved these changes
Dec 10, 2025
Contributor
Greptile OverviewGreptile SummaryAdded Key Changes:
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Client as MCP Client
participant Server as MCP Server
participant Tool as Screenshot Tool
participant Browser as Browser/CDP
participant Transport as stdout Transport
Client->>Server: call_tool(browserbase_screenshot)
Server->>Tool: handleScreenshot()
Tool->>Browser: Page.captureScreenshot()
Browser-->>Tool: screenshot data (base64)
Tool->>Tool: Process & resize image
Tool->>Tool: registerScreenshot(sessionId, name, data)
Note over Tool,Transport: Critical Fix: await notification
Tool->>Server: await notification(resources/list_changed)
Server->>Transport: Write notification to stdout
Transport-->>Server: Write complete
Server-->>Tool: Notification sent
Tool-->>Server: Return tool result
Server->>Transport: Write tool response to stdout
Transport-->>Client: Tool response
Note over Transport: Messages properly ordered:<br/>1. Notification<br/>2. Tool Response
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unawaited
notification()call that could cause message ordering issues on the transport. The notification and tool response were potentially being written concurrently to stdout